[MPlayer-dev-eng] [patch] backports/fixes from uoti demux_mkv.c for comp_algo==3

Yuriy Kaminskiy yumkam at mail.ru
Thu Aug 12 21:43:26 CEST 2010


Yuriy Kaminskiy wrote:
> Reimar Döffinger wrote:
>> On Thu, Aug 12, 2010 at 09:33:40PM +0400, Yuriy Kaminskiy wrote:
>>> +        } else if (track->encodings[i].comp_algo == 3) {
>>> +            modified = 1;
>>> +            *dest = malloc(*size + track->encodings[i].comp_settings_len);
>> Integer overflow?
> No different from zlib code just above? (and a lot code nearby)
> And there are already allocation for both *size and comp_settings_len.
> Anyway, updated patches attached (and one more to follow later...)
Not sure if that is all (and some maybe unnecessary; or solved in more nice
way), but here it is. On top of "full" series.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demux-mkv-overflows.patch
Type: text/x-diff
Size: 10535 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100812/9c95c588/attachment-0001.patch>


More information about the MPlayer-dev-eng mailing list