[MPlayer-dev-eng] [PATCH] segfault in playtree.c

Reinhard Tartler siretart at tauware.de
Thu Aug 5 06:39:52 CEST 2010


Hi Folks,

This is a patch from Adrian Knoth <adi at drcomp.erfurt.thur.de> to fix a
segfault on empty playlists.

This is Debian Bug: http://bugs.debian.org/591525

Index: playtree.c
===================================================================
--- playtree.c	(revision 31912)
+++ playtree.c	(working copy)
@@ -223,6 +223,13 @@
   assert(pt->entry_type == PLAY_TREE_ENTRY_NODE);
 #endif
 
+  /* Roughly validate input data. Both, pt and child are going to be
+   * dereferenced, hence assure they're not NULL.
+   */
+  if (NULL == pt || NULL == child) {
+      return;
+  }
+
   //DEBUG_FF: Where are the children freed?
   // Attention in using this function!
   for(iter = pt->child ; iter != NULL ; iter = iter->next)

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4


More information about the MPlayer-dev-eng mailing list