[MPlayer-dev-eng] [PATCH] Detect extern_prefix correctly on OpenBSD

[Diego Biurrun]

On Tue, Aug 03, 2010 at 12:09:15AM +0100, Edd Barrett wrote:
> 
> I am going to try and get mplayer working out of the box on OpenBSD.

Neat.

> Let's start with this:
> 
> nm prints results differently on OpenBSD than on linux. We have been using this
> following patch for a while in our ports tree.

Why is this patch necessary, what is the error?

> I hope I am correct to patch the configure script directly. I see no
> GNU autotools inputs, so I am assuming the script is written by hand.

You are correct.

> --- configure	(revision 31906)
> +++ configure	(working copy)
> @@ -2508,7 +2508,11 @@
>  cc_check -c || die "Symbol mangling check failed."
> -sym=$($_nm -P -g $TMPEXE)
> +if openbsd; then
> +  sym=$($_nm -g $TMPEXE | grep ff_extern | cut -d ' ' -f 3)
> +else
> +  sym=$($_nm -P -g $TMPEXE)
> +fi

'nm -P' is part of the POSIX standard:

http://www.opengroup.org/onlinepubs/9699919799/utilities/nm.html

If OpenBSD's nm is missing that option it would be better to fix nm
once instead of patching trillions of ports forever.

Diego