[MPlayer-dev-eng] [PATCH] New commands for loading/unloading audio filters at runtime

[Reimar Döffinger]

On Sun, Apr 11, 2010 at 08:13:46PM +0900, Jehan Pagès wrote:
> By the way, I know I am pretty new around here, but do you think there
> is a chance I might get write access to the repository? This i pretty
> tiring to make patch all the time...

You'd still be expected to submit patches for review, unless it is code
you have worked on for some time and are maintaining it, so it
wouldn't help in that case.

> Index: libaf/af.c
> ===================================================================
> --- libaf/af.c	(révision 31027)
> +++ libaf/af.c	(copie de travail)
> @@ -537,8 +537,9 @@
>    // Reinitalize the filter list
>    if(AF_OK != af_reinit(s, s->first) ||
>       AF_OK != fixup_output_format(s)){
> -    free(new);
> -    return NULL;
> +      mp_msg(MSGT_AFILTER, MSGL_WARN, "[libaf] Adding filter %s failed.\n", new->info->name);
> +      af_remove(s, new); // no need to free new, af_remove takes care of this.
> +      return NULL;

The previous reinit or fixup_output_format may have broken some things,
I'd expect you'd have to run them once more (though I haven't checked the
code).