[MPlayer-dev-eng] [Patch] info command: show progress bar and elapsed/total time

[Hugo Chargois]

Any other comments?
I find myself using it very often with my patched mplayer. I think it
is an indispensable feature of a media player, all the more since I
found that I'm not the only one who thinks so.
Any reasons why this shouldn't be included in mplayer? I would be
happy to try and correct my patch if it doesn't meet coding standards
or if you think there is a better way to do it.

Best,
Hugo.

On Wed, Mar 31, 2010 at 8:45 PM, Hugo Chargois <hugo.chargois at free.fr> wrote:
> On Wed, Mar 31, 2010 at 7:23 PM, Reimar Döffinger
> <Reimar.Doeffinger at gmx.de> wrote:
>
>> I don't much like yet another command.
>> Except for the progress bar I think it would make more sense to extend the
>> MP_CMD_OSD_SHOW_PROPERTY_TEXT function to do it...
>> Either way at least the name "info" is too unspecific.
>
> In my opinion, the fact that it represents one more command is not a
> problem. I think it is an essential function of a media player to
> display some progression info. Every gui music or move player has a
> progress bar as a central element of the interface. But I don't want
> to use a gui to mplayer, and there is/was no way to display that info
> easily, I think that is a severe lacking. (I'm not the only one who
> thinks so, I just spoke to a friend about that patch and he said that
> it was great because he was finding it lacking too. A very quick
> google search finds that same request:
> http://www.linuxquestions.org/questions/linux-software-2/getting-mplayer-display-indicate-overall-video-length-180120/
> )
>
> Moreover, it's not like the command is dangerous so that it f***s up
> the playing of the movie if you hit it inadvertently or unknowingly,
> as it just displays some info for a second or two.
>
> I guess it would be possible to move it to
> MP_CMD_OSD_SHOW_PROPERTY_TEXT but the progress bar is a must have of
> the command and then the "TEXT" part of the command seems abused.
>
> You are totally right about the name. I propose to change it to
> MP_CMD_OSD_SHOW_PROGRESSION
> I see that P is not bound, that would be a good binding IMO.
>
>
>> I think that's indented one level two much, with the strange scheme that
>> file uses I think it should be two tabs.
>> Also spaces after all "," not just select ones would be nice.
>
> Sorry about that, I totally forgot to check indentation.
>
> Thanks for sharing your thoughts.
>
> Attached is the new patch changing the name of the command and fixing indent.
>
> Hugo.
>