[MPlayer-dev-eng] [PATCH] New commands for loading/unloading audio filters at runtime

[Jehan Pagès]

Hi,

On Sat, Apr 3, 2010 at 11:31 PM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de> wrote:
> It's more that almost nobody except me reviews patches, and I'm
> a bit short on time.

Ok no problem. I was just a little scared that you did not like these
new commands.

> I guess it's a somewhat nice feature, but it should be clearly
> documented in DOCS/slave.txt that these are experimental.

Yes I understand. New features anyway should nearly always be followed
by a check period.
I added an "(experimental)" information in the description of each of
these new slave commands in slave.txt.

> While those functions are there, only the af_add one is somewhat
> tested (but still had a bugs for years that was only recently fixed),
> anyone who uses them extensively will run into major bugs.

Ok. At least I can tell that until now I haven't seen any bug, related
to the use of such functions, for this specific feature that I have
been using daily for a week now. But yeah just me is not enough. :D

Anyway I can stay around as long as needed to maintain these specific
slave commands, and extend my maintenance to the functions I use in
these commands' code (though I am not a big fan/user of mailing lists
so of course do not hesitate to ping me through private emails if I
don't see a bug report on the list).

> I'd even suggest to recommend that any application using them
> should provide a way to make it run without using them, too.

Should I add such a recommendation in the slave.txt as well? Maybe I
can add a passage in the introductory text of slave.txt, with such a
recommendation about any command featuring an "experimental" tag in
its description. Though I am not sure this is really necessary. I
mean: the word "experimental" itself is already pretty well self
explanatory, isn't it?

Anyway I attached the latest version of the patch, with the
"(experimental)" tag in slaves.txt (but not the recommendation text
yet as I wait whether this suits you the way it is now), and a small
add to my code (just a test at the beginning of execution of these
commands, to break if there is no sh_audio, as obviously dealing with
audio filter is useless then).
Bye.

Jehan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer_af_filters.patch
Type: text/x-patch
Size: 4787 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100404/4127b26f/attachment.bin>