[MPlayer-dev-eng] tabs removal

Diego Biurrun diego at biurrun.de
Sat Apr 3 17:04:48 CEST 2010


On Sat, Apr 03, 2010 at 04:38:51PM +0200, Reimar Döffinger wrote:
> On Sat, Apr 03, 2010 at 02:54:31PM +0200, Diego Biurrun wrote:
> > I intend to convert all tabs to four spaces outside of Makefiles and
> > imported code and then activate the pre-commit hook that prevents fresh
> > ones from being added.
> 
> I still have no objections, but I know others very much disliked the idea.

This is the type of decision that should be decided by majority and
then whoever got overruled should just act professional and accept
the decision.  Letting these things stall forever is the worst
possible outcome.

> Note that the OpenGL code uses 2 spaces indentation - I don't mind _much_
> changing that, but warn me before you change that if you intend to.
> For unmaintained files I'd consider it within my authority to give you
> permission to do such changes immediately.
> I'd appreciate it also if you sanity-check your commits with the
> svn diff -x -uwb
> command from svn-howto (should produce an empty diff) and maybe also
> check the md5sum of the generated binary stays the same (at least after
> stripping the debug info) if the changes are really huge.

Sure.

Diego



More information about the MPlayer-dev-eng mailing list