[MPlayer-dev-eng] [PATCH] alsa: use buffer_time_min instead of buffer_time_near

Uoti Urpala uoti.urpala at pp1.inet.fi
Tue Sep 29 15:09:15 CEST 2009


On Tue, 2009-09-29 at 10:24 +0200, Reimar Döffinger wrote:
> Take this as another real-world proof why it is really stupid to mix
> cosmetic with functional changes.

Your message is another real-world proof of how people stuck in their
habits can make up really stupid arguments in an attempt to justify not
changing their behavior.

The change in question was to code that was effectively under #if 0.
Thus any "change" was of little significance as you couldn't assume much
about the code that was there before. The code could just as well have
been added from scratch in that commit. The previous code also had an
analogous problem for other variables.

This commit had nothing to do with the cases most commonly affected by
your quirks. Using it to justify your insistence on spamming separate
commits to reindent a couple of lines or even a single line is silly.




More information about the MPlayer-dev-eng mailing list