[MPlayer-dev-eng] [PATCH] properly check for i386 vs. x86_64

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Sep 24 11:19:45 CEST 2009


On Thu, Sep 24, 2009 at 11:02:58AM +0200, Diego Biurrun wrote:
> On Thu, Sep 17, 2009 at 08:52:06PM +0200, Reimar Döffinger wrote:
> > current check is unreliable and e.g. fails on systems with 32 bit gcc
> > but -m64 used or just plain wrong uname -m/uname -p
> > It is a bit ugly because TMPC is set so late (must be after OS detection
> > to be together with TMPEXE).
> 
> Hmm..
> 
> > It might make sense to split apart OS and CPU detection instead.
> 
> Probably..
> 
> Patch OK.  I see you already applied it, fine with me.  Sorry for the
> late review.

Uh, yeah, sorry I forgot to say "applied".
Hopefully MPlayer is now close to compiling on OSX 10.6 out-of-the-box
(if someone wants to offer me a shell account on such a system I
wouldn't mind :-) ).



More information about the MPlayer-dev-eng mailing list