[MPlayer-dev-eng] [PATCH] VF Overlay

[Diego Biurrun]

On Tue, Sep 22, 2009 at 06:54:24PM +0200, Benjamin Zores wrote:
> 
> Resurecting an old patch now ...
> Attached is latest version of the patch.
> Tack, have you done any changes or is it OK for everyone to finally get 
> this applied ?

There is one thing that makes me wonder..

> --- mencoder.c	(revision 29701)
> +++ mencoder.c	(working copy)
> @@ -218,6 +218,11 @@
>  
> +// Stubs for filters that might call these functions, to satisfy linker.
> +// These filters are probably only useful for MPlayer.
> +void mp_input_add_cmd_filter(void *func, void* ctx) {}
> +void *mp_input_get_cmd(int time, int paused, int peek_only) { return NULL; }

This should be unnecessary.

> --- Makefile	(revision 29701)
> +++ Makefile	(working copy)
> @@ -112,6 +112,7 @@
>  SRCS_COMMON-$(HAVE_POSIX_SELECT)     += libmpcodecs/vf_bmovl.c
> +SRCS_COMMON-$(HAVE_SHM)              += libmpcodecs/vf_overlay.c
>  SRCS_COMMON-$(HAVE_SYS_MMAN_H)       += libaf/af_export.c osdep/mmap_anon.c

Why don't you add this to SRCS_MPLAYER instead, that should do the
trick.

Diego