[MPlayer-dev-eng] [PATCH] VF Overlay

[Uoti Urpala]

On Tue, 2009-09-22 at 18:54 +0200, Benjamin Zores wrote:
> Jason Tackaberry wrote:
> > On Wed, 2009-08-19 at 02:03 +0200, Benjamin Zores wrote:
> >> Tack, as you wrote the ASM code, can you have a look at this ?
> >> Also, I've noticed you now have a write account so feel free to commit 
> >> this patch whenever you feel it ready as you're the main author (I've 
> >> only performed a few fixes/enhancements on it after all).
> > 
> > Ok, I'll incorporate Reimar's suggestions hopefully next week and
> > resubmit.
> 
> Resurecting an old patch now ...
> Attached is latest version of the patch.
> Tack, have you done any changes or is it OK for everyone to finally get 
> this applied ?

In addition to any direct bugs in the code this approach still suffers
from the same fundamental problems as it did in earlier incarnations.
Now the pause hacks have been removed, which makes the patch less
actively harmful in the sense that it can be ignored or easily deleted
later without affecting anything else; but OTOH that makes its
deficiency as an overlay implementation more apparent than ever. I
wouldn't want any frontends to start relying on it. IMO the included
documentation is actually counterproductive in that regard; if applied
at all leaving it deliberately undocumented might actually be better. At
least there should be clear warnings that this functionality is not
supported, may arbitrarily fail depending on other settings, and may be
completely disabled or removed at any time.