[MPlayer-dev-eng] [PATCH] demux_audio - be stricter when recognizing WAV format

[Reimar Döffinger]

On Thu, Sep 10, 2009 at 11:45:50AM -0500, Daniel Verkamp wrote:
> On Tue, Sep 8, 2009 at 7:15 PM, compn<tempn at twmi.rr.com> wrote:
> > On Wed, 9 Sep 2009 01:22:33 +0200, Reimar Döffinger wrote:
> >>On Tue, Sep 08, 2009 at 05:23:59PM -0500, Daniel Verkamp wrote:
> >>> Currently, demux_audio picks up Sony Wave64 files as plain WAV due to
> >>> the fmt chunk being recognized.  The attached patch adds an extra
> >>> check so that the RIFF and WAVE chunks must be seen first to recognize
> >>> a fmt chunk as indicating a WAV-format file.  This allows W64 files to
> >>> fall through to lavf.
> >>
> >>The simpler and probably better solution would be to add your demuxer to
> >>the preferred formats.
> >
> > in demux_lavf.c or extension.c ?
> >
> > but yeah, your change might break some wav files ...
> >
> > -compn
> 
> Presumably this is the desired change; I guess the list is not ordered
> any particular way?

If it works, yes I think this is the best solution.
And it is supposed to be ordered alphabetically (which it still is after
your patch, so no issues there).