[MPlayer-dev-eng] [PATCH] Add support for directory-wide configuration overrides V4.1

Christian P. Schmidt schmidt at digadd.de
Thu Sep 3 10:52:11 CEST 2009


Reimar Döffinger wrote:
> AFAIK it is used for URLs, too. Though I think that's not a great loss
> if it doesn't work for huge URLs, and also instead of crashing it could
> print a proper error message. But I think I'll take care of that myself.
> Also PATH_MAX on Unix(-like) systems is usually around a page size, or 4kB,
> which is plenty even for URLs. Of course Windows as always is a problem
> with only 260.

>From libAST headers, might be interesting for you:

/**
 * @def PATH_MAX
 * The maximum length of a path specifier.
 *
 * LibAST requires PATH_MAX to be properly defined.  Unfortunately,
 * some UNIX versions (namely HP-UX) define it incorrectly.  Most UNIX
 * versions support a PATH_MAX of 1024, but all must support at least
 * 255.  So if PATH_MAX is defined to be less than 255 (like HP-UX and
 * its absolutely ludicrous value of 14), LibAST forceably redefines
 * it to be 255.
 * @see @link DOXGRP_CONF Configuration File Parser @endlink
 * @ingroup DOXGRP_CONF
 */
#if defined(PATH_MAX) && (PATH_MAX < 255)
#  undef PATH_MAX
#endif
#ifndef PATH_MAX
#  define PATH_MAX 255
#endif

On linux x86_64 it indeed is 4096.

> Anyway, patch is applied and thanks for staying on during the review
> process.

Thank you for that.

Regards,
Christian



More information about the MPlayer-dev-eng mailing list