[MPlayer-dev-eng] [PATCH] DVDNAV support improve (change audio and subtitle by dvd menu) and other things

[Nico Sabbi]

Il martedì 1 settembre 2009 01:15:49 Carl Eugen Hoyos ha scritto:
> Hi!
>
> Jaime Gemelo <gemelo.jaime <at> yahoo.fr> writes:
> > Here is a patch that  resolves some things ;) :
>
> One patch on this list is expected to fix/implement exactly one
> thing: Some things => some patches
>
> [...]
>
> > To apply this patch, launch this command: patch -p1 -i "name of
> > the patch"
>
> While everybody here is expected to know how to use patch, please
> prepare your patches by using "svn diff" - we believe everything
> else is unreadable.
>
> Just two cosmetic comments:
> There is one occurrence of trailing white space in the patch -
> please remove it. And I believe
>   if (A)
>     if (B)
>       C();
> should be written as
>   if (A && B)
>     C();
>
> Carl Eugen
>

I agree completely