[MPlayer-dev-eng] [PATCH] AVParser for audio support

Uoti Urpala uoti.urpala at pp1.inet.fi
Fri Oct 30 20:01:18 CET 2009


On Fri, 2009-10-30 at 19:11 +0100, Reimar Döffinger wrote:
> On Fri, Oct 30, 2009 at 03:05:24PM +0100, Diego Biurrun wrote:
> > I'm once again getting tempted to just apply this instead of seeing it
> > rot ...
> 
> Well, if you want _I_ won't flame you for applying it.
> It's not working perfectly with the FFmpeg decoders (seeking in MP3 gives
> quite some noise with FFmpeg decoder) but I have not seen any regressions
> in my tests, and I don't care whether I clean it up/improve it in SVN
> or before.

IIRC the last posted version still has significant issues in both design
and functionality. The code is one the wrong side of the packet queue
(should be on the read side, now it's on the write side), still creates
bogus 0-size packets, and sets the same pts from the original packet in
every parsed subpacket even though it can only sensibly apply to the
first one.




More information about the MPlayer-dev-eng mailing list