[MPlayer-dev-eng] [PATCH] Add DVB teletext support

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Oct 29 15:50:18 CET 2009


On Thu, Oct 29, 2009 at 11:08:50AM +0000, Carl Eugen Hoyos wrote:
> Francesco Lavra <francescolavra <at> interfree.it> writes:
> 
> > > The first patch deals with file name changes and must be preceded by:
> > >         svn mv stream/tvi_vbi.c libmpcodecs/dec_teletext.c
> > >         svn cp stream/tv.h libmpcodecs/dec_teletext.h
> 
> I will apply this hunk if nobody objects.

That is the first diff?
Seems ok.
But I think the TVI -> VBI renaming stuff should be applied shortly after, too.
Most of that is in patch 2, but unfortunately patch 2 also contains stuff like adding
demuxer->teletext which IMO needs some thinking about or at least a proper review,
which is hard to do while it is among those huge "cosmetic" changes.



More information about the MPlayer-dev-eng mailing list