[MPlayer-dev-eng] [PATCH] 2nd try: add -name and -title options for x video_outs

[Paul TT]

On Wed, 28 Oct 2009 17:58:39 +0100
Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:

> On Wed, Oct 28, 2009 at 05:53:15PM +0100, Paul TT wrote:
> > Index: DOCS/man/en/mplayer.1
> > ===================================================================
> > --- DOCS/man/en/mplayer.1	(revisione 29800)
> > +++ DOCS/man/en/mplayer.1	(copia locale)
> > @@ -3277,6 +3277,22 @@
> >  API please use \-heartbeat\-cmd instead.
> >  .
> >  .TP
> > +.B \-title (also see \-use\-filename\-title)
> > +Set the window title.
> > +Supported by X11 based video output drivers.
> > +.br
> > +.I WARNING:
> > +Does not work with \-fixed\-vo.
> 
> Why does that one not work with -fixed-vo?

i wrote badly the man, indeed, your question made me notice that.
it sould be corrected to say:
"Whn used with \-fixed\-vo it works only as a global option."
the meaning is it does not work if used with -fixed-vo and option
specific to single file...


> > @@ -3054,9 +3055,12 @@
> >  }
> >  //---------------------------------------------------------------------------
> >  
> > -    if(filename)
> > +    if(filename) {
> >  	mp_msg(MSGT_CPLAYER,MSGL_INFO,MSGTR_Playing,
> >  		filename_recode(filename));
> > +        if(use_filename_title && vo_wintitle == NULL) 
> > +            vo_wintitle = strdup ( mp_basename2 (filename));
> 
> Hmm... wouldn't it maybe be nicer to append the filename to
> vo_wintitle instead?

something like
MPlayer - This movie is playing.avi
????
imho it would be nice, but with long filenames and showrt width it
could be worse than no title :(
what do you think?