[MPlayer-dev-eng] [PATCH] Add support for ARIB STD-B24 captions v4

[Diego Biurrun]

On Mon, Oct 26, 2009 at 10:48:25PM -0400, Michael Wu wrote:
> 
> These patches add support for ARIB STD-B24 captions.
> 
> Changes:
> - Clean up configure changes
> - Put ARIB part of makefile change in alphabetical order
> - Use void in parameterless functions in sub_arib.c
> - Add copyright/license to sub_arib.h

Much of what I noticed during my last review still applies.

> --- sub_arib.h	(revision 0)
> +++ sub_arib.h	(revision 0)
> @@ -0,0 +1,27 @@
> +
> +#ifdef CONFIG_ARIB
> +
> +#include "libass/ass_mp.h"
> +
> +void arib_process_data_group(unsigned char *data, int len, double subpts, ass_track_t *track);
> +
> +#else
> +
> +void arib_process_data_group(unsigned char *data, int len, double subpts, void *track) {};
> +
> +#endif /* CONFIG_ARIB */

This #ifdeffery is extremely ugly and unacceptable.

Diego