[MPlayer-dev-eng] [PATCH] Add support for ARIB STD-B24 captions v2

Michael Wu altape at ymail.com
Mon Oct 26 19:19:52 CET 2009


--- On Mon, 10/26/09, Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> Michael Wu wrote:
> > --- On Mon, 10/26/09, Uoti Urpala <uoti.urpala at pp1.inet..fi>
> wrote:
> > > +#define arib_stub(...) mp_msg(MSGT_ARIB,
> MSGL_WARN, __VA_ARGS__)
> > > 
> > > +     
>    arib_stub("cc: APB\n");
> > > 
> > > Messages like these will confuse most users...
> > > 
> > > 
> > I'll just convert everything to dbg then. The spec is
> quite big and I'm not sure which parts are actually used in
> real streams, so these messages are set up in the hopes that
> users will report them if they find streams that uses those
> features. However, I think I've implemented enough of the
> spec that most users won't end up noticing or caring about
> these messages. I should be playing enough arib ts's to find
> the remaining issues anyway..
> 
> I think it'd be OK to have them at warning level, but the
> message should
> have enough detail to tell it is about missing features in
> the arib
> decoder. Just "cc: APB" is meaningless if you don't already
> know what
> those messages are about.
> 
Ok, I'll make them more descriptive.

> BTW your mailer linewraps quotes in a manner that totally
> mangles them,
> while at the same time your own comments aren't wrapped at
> all and are
> on a single long line.

Yeah, sorry about that. I noticed it too after sending.

I thought that yahoo mail would be decent now that they have
gmail as an example of what to do, but apparently it's still
trash. (albeit pretty and web 2.0 looking) Gonna switch to a
different email account.

Thanks,
-Michael Wu


      




More information about the MPlayer-dev-eng mailing list