[MPlayer-dev-eng] [PATCH] trivial changes to suppress compiler warnings

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Oct 23 20:43:22 CEST 2009


On Fri, Oct 23, 2009 at 07:48:34PM +0200, Diego Biurrun wrote:
> On Thu, Oct 22, 2009 at 03:25:19PM +0200, Reimar Döffinger wrote:
> > On Thu, Oct 22, 2009 at 02:00:30PM +0200, Diego Biurrun wrote:
> > > --- libvo/x11_common.c	(revision 29789)
> > > +++ libvo/x11_common.c	(working copy)
> > > @@ -1341,7 +1341,7 @@
> > >  
> > >  void vo_x11_fullscreen(void)
> > >  {
> > > -    int x, y, w, h;
> > > +    int x=0, y=0, w=0, h=0;
> > 
> > The whole code of this function should probably be written in a better
> > way, but here specifically I'd suggest just moving the
> >             x = vo_old_x;
> >             y = vo_old_y;
> >             w = vo_old_width;
> >             h = vo_old_height;
> > part up here.
> 
> Like $attached?

Yes, looks fine to me (of course an extra check can't hurt).



More information about the MPlayer-dev-eng mailing list