[MPlayer-dev-eng] [PATCH]Fix possible memlead in vo_vdpau

Carl Eugen Hoyos cehoyos at ag.or.at
Thu Oct 22 21:06:32 CEST 2009


Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:

> On Sat, Oct 10, 2009 at 03:46:26PM +0000, Carl Eugen Hoyos wrote:
> > > I don't have a suggestion how to fix this right now though (IMO this
> > > should be done on avcodec_close, but this opens up some ugly issues),
> > > but at least I'd suggest to do this in uninit.
> > 
> > Is the following (inlined) acceptable?
> 
> If it works and fixes the issue (also test with multiple videos and
> with/without fixed-vo, to make sure uninit is the right place - if it
> doesn't work free_video_specific might be the right one) I'd say it's ok.

I verified that the buffers are actually freed, even if several videos are
played with fixed-vo.
Patch applied, Carl EUgen







More information about the MPlayer-dev-eng mailing list