[MPlayer-dev-eng] [PATCH] VDPAU: add studio level RGB output

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Oct 11 09:35:01 CEST 2009

On Sun, Oct 11, 2009 at 10:07:38AM +0300, Lauri Mylläri wrote:
> I will add a similar eq that vo_gl uses if the idea otherwise seems ok
> for inclusion. Again, comments,fixes and improvements would be
> welcome.

Please reuse the code from get_yuv2rgb_coeffs in libvo/gl_common.c in
some way.
Making a bad copy of it that doesn't compile with gcc 2.95 and does not
support equalizer settings while extending it by a feature that vo_gl
could easily support as well is far, far from acceptable, it lead to the
kind of mess we are still dealing where every vo works slightly
different even though they all supposedly implemented the same thing.
In light of that, it might also be better if at least the colourspace
selection stuff that does not depend on VDPAU-specific stuff but uses
custom matrices would be selectable via global parameters and if
libswscale would make use of it, too, but that might be too much work to
do right now.

More information about the MPlayer-dev-eng mailing list