[MPlayer-dev-eng] [PATCH] remove many tmp_run usages

[Diego Biurrun]

On Sat, Oct 03, 2009 at 05:08:05PM +0200, Reimar Döffinger wrote:
> Almost all those checks are either pointless or checking
> for _completely_, absolutely 100% broken setups (which in addition
> all those libraries could have avoided with a hack like x264 does),
> which I really don't think is our responsibility to check for.
> Also, if done properly these issues (e.g. header and library mismatch)
> would have to be checked at MPlayer runtime, otherwise the issue
> can still crop up when binaries are distributed.
> Removing these checks IMO is an improvement, because less program runs
> means faster configure, particularly on Windows and OSX, it removes
> a bit of extra complexity (some of the C programs for the checks
> should/could be simplified afterwards), and it also avoids issues liek
> this one: http://bugs.gentoo.org/show_bug.cgi?id=287262

I agree, commit anytime.

> --- configure	(revision 29748)
> +++ configure	(working copy)
> @@ -4949,11 +4949,7 @@
>      if cc_check -lpng -lz $_ld_lm ; then
> -      if tmp_run ; then
> -        _png=yes
> -      else
> -        _res_comment="mismatch of library and header versions"
> -      fi
> +      _png=yes
>      fi
> @@ -5001,9 +4997,7 @@
>      if cc_check -ljpeg $_ld_lm ; then
> -      if tmp_run ; then
> -        _jpeg=yes
> -      fi
> +      _jpeg=yes
>      fi

Please simplify these to

foo && _bar=yes

while you're at it.

Diego