[MPlayer-dev-eng] [PATCH] 2nd try: add -name and -title options for x video_outs

[Paul TT]

On Mon, 9 Nov 2009 19:25:05 +0100
Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:

> On Wed, Oct 28, 2009 at 07:01:01PM +0100, Paul TT wrote:
> > On Wed, 28 Oct 2009 17:58:39 +0100
> > Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> > 
> > > On Wed, Oct 28, 2009 at 05:53:15PM +0100, Paul TT wrote:
> > > > Index: DOCS/man/en/mplayer.1
> > > > ===================================================================
> > > > --- DOCS/man/en/mplayer.1	(revisione 29800)
> > > > +++ DOCS/man/en/mplayer.1	(copia locale)
> > > > @@ -3277,6 +3277,22 @@
> > > >  API please use \-heartbeat\-cmd instead.
> > > >  .
> > > >  .TP
> > > > +.B \-title (also see \-use\-filename\-title)
> > > > +Set the window title.
> > > > +Supported by X11 based video output drivers.
> > > > +.br
> > > > +.I WARNING:
> > > > +Does not work with \-fixed\-vo.
> > > 
> > > Why does that one not work with -fixed-vo?
> > 
> > i wrote badly the man, indeed, your question made me notice that.
> > it sould be corrected to say:
> > "Whn used with \-fixed\-vo it works only as a global option."
> > the meaning is it does not work if used with -fixed-vo and option
> > specific to single file...
> 
> I admit I haven't looked much at it, but the obvious question is:
> can't it be made to work with it?
yes, it can be done!
(i already looked at it, but i was in trouble finding the way, but i
noticed that even with fixed-vo, the size of the window it's updated,
so i did the same for the title part, see:
i added thiese lines into vo_x11_update_geometry (x11_common.c)

   if (vo_wintitle)
        XStoreName(mDisplay, vo_window, vo_wintitle);

just before the return. in this way it works! good :)
i'll apply tomorrow, ok?

...
> > what do you think?
> 
> Well, I had thought of literally appending it,
> vo_wintitle = "MPlayer"
> playing movie.avi
> results in
> MPlayermovie.avi
i don't like it, not very much readable, imho :(
> whereas your example could be achieved with
> vo_wintitle = "MPlayer - "
> I just realize that this wraps together with the -fixed-vo issue,
> you can't handle this properly because you override the user-give
> vo_wintitle instead of building the complete title into some other
> variable.
yes
anyway i don't like to extend the title over the filename.
suppose you're looking at "The new very serial episodes reallly
cool.recorded.by.jumble.jumble.peter_HDVERSION_ROTFL_LOL_LOL_XXX_S01Ep.02.avi"
and this with a little resolution.
you'll see seomthing like
"Mplayer - T...Ep.02.avi"
which tells you nothing about the clip, or
"The new very ...vi - Mplayer"
which again doesn't tell you nothing about the episode youre looking at.
i thing it's easy to vanify the information by appending
MPlayer-or-something-else to the title.
hey, the default behaviour will be yet to title only MPlayer, so if you
change it, you already know you're using MPlayer....

(sorry for mail's length)

bye and thanx again
Paul