[MPlayer-dev-eng] [PATCH] 8 channel support

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Nov 4 14:03:01 CET 2009


On Wed, Nov 04, 2009 at 12:24:07PM +0100, Clemens Ladisch wrote:
> Reimar Döffinger wrote:
> > > +	case 8:
> > > +	  if (alsa_format == SND_PCM_FORMAT_FLOAT_LE)
> > > +	    device.str = "plug:surround71";
> > > +	  else
> > > +	    device.str = "surround71";
> > 
> > Hm, is that plug: thing still necessary with current ALSA?
> 
> Yes (if the intention is to have ALSA instead of mplayer to do the
> float->int conversions for devices that don't support float samples).
> 
> The log of r12571 doesn't say why this was introduced in the first
> place; was there no float->int converter then?

I suspect that MPlayer could not reliably detect that float was not
supported and thus you'd end up with no audio at all since neither
MPlayer nor ALSA were doing the conversion.



More information about the MPlayer-dev-eng mailing list