[MPlayer-dev-eng] [PATCH][TRIVIAL] Few cosmetics to x11_common

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Nov 4 10:00:22 CET 2009


On Wed, Nov 04, 2009 at 07:53:39AM +0100, Diego Biurrun wrote:
> On Wed, Nov 04, 2009 at 07:15:55AM +0200, Uoti Urpala wrote:
> > On Tue, 2009-11-03 at 19:44 -0300, Reynaldo H. Verdejo Pinochet wrote:
> > > Reimar Döffinger wrote
> > > > 
> > > > I.e. split it into setup of "helper data", the cursor (our real goal) creation
> > > > and setting, and freeing the "helper data".
> > > > But this is of course a bikeshed issue...
> > > 
> > > Not at all. I have no bike and no much paint left neither. I
> > 
> > But you are still wasting time on trivialities. As you yourself put in
> > the thread title: trivial, a couple of cosmetics. Not worth the noise
> > you are creating about it.
> 
> Alternative: Just commit now without further back and forth about it.
> I'll choose the paint can for you to end this: Get the file as close to
> K&R as you wish; keep the braces.

I think I'm fine by it as long as it is not a multi-MB thousands of
lines change, but more of the size as what you posted.
Having it split by topic (linbreak changes, ...) would be a plus.



More information about the MPlayer-dev-eng mailing list