[MPlayer-dev-eng] [PATCH] libass BorderStyle==3 fix

[Evgeniy Stepanov]

On Saturday 30 May 2009 16:48:07 Rinat wrote:
> This patch inserts a opaque box before glyphs in event_images->imgs list if
> current event style have 'BorderStyle' property equal 3. But my code does
> not check for frame bounds because I cant find out where to get them.

That's ok, this bitmaps are supposed to be clipped later. And, I think, border 
width does not affect text placement, so glyphs near frame edge with wide 
outlines will be clipped anyway.

> And
> maybe expanding background box by 'Outline' pixels is not correct.

It makes sense.

It seems you also need to disable outline and shadow glyphs in this case. And 
you are adding a memory leak of backai->bitmap. It's a little unintuitive, but 
bitmap buffer is not owned by ass_image_t, and not freed with them. Normally, 
it's a pointer to bitmap_t memory. You can place this buffer in ass_renderer_t 
and grow it as needed.