[MPlayer-dev-eng] [PATCH] Use local labels to avoid clashes caused by -ftracer

[Luca Barbato]

Reimar Döffinger wrote:
> On Tue, May 26, 2009 at 10:30:09PM +0200, Luca Barbato wrote:
>> mp3lib has some inline asm using .LNN labels, -ftracer makes that block
>> appear twice, the labels clash, using local labels the problem
>> disappear. I picked the numeric over the $ notation, maybe the latter is
>> more readable.
> 
> Are you sure this works? I think for local labels at the jump location you have to
> add a "f" or "b" depending on jump direction?

f and b are to point to the forward and backward redefinition, I assumed
the plain label would work as is, probably I should put a 'b':

>From [1]

"Here is an example:

     1:        branch 1f
     2:        branch 1b
     1:        branch 2f
     2:        branch 1b

Which is the equivalent of:

     label_1:  branch label_3
     label_2:  branch label_1
     label_3:  branch label_4
     label_4:  branch label_3
"

I wonder why it built and apparently works.

[1]http://sourceware.org/binutils/docs/as/Symbol-Names.html#Symbol-Names


-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero