[MPlayer-dev-eng] [PATCH] Fix segfault in libmpcodecs/ad_imaadpcm.c

[Reimar Döffinger]

On Sun, May 10, 2009 at 02:10:12PM +0200, Aurelien Jacobs wrote:
> On Sun, May 10, 2009 at 11:15:24AM +0200, Reimar Döffinger wrote:
> > [...]
> > 
> > Independent of this, isn't the libavcodec imaadpcm decoder the default
> > nowadays? I haven't completely checked it yet, but it might be better in
> > the long term to just remove this code.
> 
> I had the exact same reaction when reading this...
> Why the hell is there still a native imaadpcm decoder in MPlayer ??

Several of the ADPCM decoders in FFmpeg were buggy, I went through them
comparing the code and switching to FFmpeg, I don't think I managed to
finish.
The native ones definitely should not be removed without checking, as
said the FFmpeg implementation had quite a few bugs/incomplete
implementations in other cases (not that the native ones don't have
bugs, but they seem to be at least more tested).