[MPlayer-dev-eng] [PATCH] add -ldvdcss when dvdcss is external

[Uoti Urpala]

On Fri, 2009-05-08 at 22:26 +0100, vmrsss wrote:
> On 8 May 2009, at 20:52, Uoti Urpala wrote:
> > So your libdvdread has been directly linked against libdvdcss. Where  
> > did
> > you get that libdvdread binary from?
> 
> No, libdvdread not linked against lidvdcss at all.

Actually the other way around - your libdvdread shared library directly
uses a symbol from libdvdcss, so it _should_ link against it, but does
not.

>  And it was not a   
> binary, it's compiled from here

So it was a binary you compiled yourself.


I checked the dvdread code, and it seems to have support for both a
linking mode and a mode using dlopen(). Unless there is some special
reason to do otherwise, I'd say this is a bug in libdvdread (at least in
the version you compiled)- when it is compiled for direct use of the
symbols (non-dlopen version) it should link the shared library against
libdvdcss. MPlayer should not have to give any -l flags for indirect
dependencies of shared libraries.