[MPlayer-dev-eng] [PATCH] remove a bunch of const qualifiers to get rid of compiler warnings

[Uoti Urpala]

On Wed, 2009-05-06 at 04:39 +0400, Andrew Savchenko wrote:
> On Tuesday 05 May 2009, Diego Biurrun wrote:
> > On Tue, May 05, 2009 at 09:24:21PM +0300, Uoti Urpala wrote:
> > > On Tue, 2009-05-05 at 20:10 +0200, Diego Biurrun wrote:
> > > > $attached removes const qualifiers from array declarations
> > > > where gcc was warning about 'initialization discards
> > > > qualifiers from pointer target type'.
> > > >
> > > > This eliminates all the remaining warnings on mplayer.c and
> > > > mencoder.c. I'm not sure this is the best solution though.
> > >
> > > That's wrong, those arrays are clearly constant (any code
> > > trying to change them would be badly broken).
> >
> > Is there a solution that gets rid of the warnings?
> 
> An attached patch should fix all issues with mplayer's native code 
> on my system (obviously I can't complie all possible modules and 
> subsystems). Though, some discarded qualifier appears into svn 
> external stuff (libav*) and libswscale, so they aren't fixed here.

At least the control() changes are wrong (data can be returned through
the parameter pointer). Some other things looked questionable, quite
possibly there are other errors.

No more iterative attempts to get warning fixes right please. If someone
who can do it right silences warnings that's good, but at least I don't
consider it worth my time to evaluate questionable warning fix patches.
If it takes multiple tries to get them right that uses much more time
than silencing warnings myself, and I think there are more important
things to do.