[MPlayer-dev-eng] [PATCH] remove a bunch of const qualifiers to get rid of compiler warnings

Andrew Savchenko bircoph at gmail.com
Tue May 5 23:47:03 CEST 2009


Hi,

On Tuesday 05 May 2009, Diego Biurrun wrote:
> On Tue, May 05, 2009 at 09:24:21PM +0300, Uoti Urpala wrote:
> > On Tue, 2009-05-05 at 20:10 +0200, Diego Biurrun wrote:
> > > $attached removes const qualifiers from array declarations
> > > where gcc was warning about 'initialization discards
> > > qualifiers from pointer target type'.
> > >
> > > This eliminates all the remaining warnings on mplayer.c and
> > > mencoder.c. I'm not sure this is the best solution though.
> >
> > That's wrong, those arrays are clearly constant (any code
> > trying to change them would be badly broken).
>
> Is there a solution that gets rid of the warnings?

It's obvious: to fix the code. Perhaps in some places objects in 
question are indeed non-constant, perhaps gcc bugs shows up 
somewhere. Each single group should be reviewed separately.

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090506/49e7811f/attachment.pgp>


More information about the MPlayer-dev-eng mailing list