[MPlayer-dev-eng] [PATCH] patch 1: vdpau

[Dan Oscarsson]

On 2009-05-04 at 17:19 +0300 Uoti Urpala wrote: 
> That's false. You must be assuming some different kind of
> implementation. What I talked about above was basically adding a test
> before calling flip_page: "Would this flip_page() call be late by at
> least amount x? If so then skip it.". This would certainly be a lot
> simpler than your patches.

To be able to answer that question correctly you probably need most of
my patches (or equivalent code). I am nor sure a simpler check will work
well enough. For example, in my code I use as a default a max delay of
1,3 vsync becuse having just 1 results in jitter that results in many
frame drops. A simple handling probably can answer give a resolution of
1 not not fractions. Looking forward to see your code and to test how
well it works.

> xv could additionally need a XSync() call in
> a suitable place, since I've seen behavior where lots of video updates
> accumulate in the X command queue (so from MPlayer's point of view the
> flips have happened, but in fact they've only been queued).

XSync is what vo sdl uses and that is what makes sdl get out of sync.
XSync will force mplayer to wait until the vsync occurs and that makes
mplayer lose audio syncunless -framedrop is active. This is the same
problem that current vdpau code has - it also waits.

> The work itself will not take that long. I'm not yet sure when I'll do
> it.

OK. I can test it, when you have done it, if you like me to.