[MPlayer-dev-eng] [PATCH] vo_macosx: process events with shared_buffer (and patch roundup)

[Adrian Stutz]

On Mon, May 4, 2009 at 9:34 AM, Guillaume POIRIER <poirierg at gmail.com>wrote:

> > On Apr 22, 2009, at 19:16, Michael Guntsche wrote:
> >
> >> Hi, looking at the patch Adrian posted I wondered if we even NEED to
> >> forward the events to Nsapp anyway, since normally in the case of
> >> running with a shared_buffer the GUI application takes care of parsing
> all
> >> the events anyway.
>
> Well, I'm kinda expecting Adrian to give his feedback about your
> patch. I'm sure that his analysis of your patch would be more
> meaningful than mine.
>

Well, it's not that I'm much veresed in this issue. There's also no related
documentation I could find.

Anyway, I wondered what kind of events MPlayer receives and decided to
check. Turns out it doesn't receive any events at all, so there was never
anything forwarded to NSApp.

I think Michael's patch is sensible in this case, though I think it also
needs an autorelease pool so we don't leak any memory until MPlayer is
closed. I haven't tested if it's the case for this specific NSApp message
but Cocoa generally expects an autorelease pool to be in place.

Attached is an updated version of Michael's patch adding an autorelease
pool.

I've also updated the flip_page patch to apply to the renamed vo_corevideo.

Greetings
Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_corevideo_check_events.patch
Type: text/x-diff
Size: 511 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090504/7a593f50/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_corevideo_flip_page.patch
Type: text/x-diff
Size: 480 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090504/7a593f50/attachment-0001.patch>