[MPlayer-dev-eng] [PATCH] MMS/ASF minor changes (ASF header file / 2)

Francesco Cosoleto cosoleto at gmail.com
Mon Mar 30 00:35:25 CEST 2009


Reimar Döffinger wrote:
> "flags" isn't any better a name. Even if it was, the renaming alone
> would have to be a separate patch. I also think you did not test
> compilation since you forget to replace one stream_no in the le2me macro.

Ouch! So definitely I have to *increase* the font size to kdiff, 
previous posted patch was ok on big-endian machines...

> The parts changing the comment and adding the & 0x7F where missing
> are of course ok though.

"flags" should be the correct name, I don't know how to rename 
otherwise. Maybe it's preferable to edit the source code where the 
context mades 'flags' not clear.

Patch updated.

-- 
Francesco Cosoleto | http://cosoleto.free.fr

"[gli industriali italiani] più speculatori che imprenditori" (Massimo 
Paci, ex INPS)

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 1_missing_0x7F.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090330/65c1ca0b/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 2_rename.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090330/65c1ca0b/attachment.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 3_doc_up.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090330/65c1ca0b/attachment-0001.txt>


More information about the MPlayer-dev-eng mailing list