[MPlayer-dev-eng] [PATCH] libbs2b audio filter

[Andrew Savchenko]

Hi,

On Sunday 29 March 2009 03:51, Uoti Urpala wrote:
[...]
> > > As far as I can tell I did not misread your message, but you
> > > did not understand what I said. What I meant was that at
> > > best your "special error code" suggestion turns "uninit();
> > > return ERROR;" into "return MAGIC_ERROR_CODE;".
> >
> > Nope, my idea differs, maybe my original explanation was
> > unclear. I do not propose to call uninit in each filter before
> > return. I propose to modify filter initializer in af.c, thus
> > this will be single modification affects all filters at once,
> > e.g.:
>
> This still sounds exactly like how I interpreted it the first
> time. Yes you do not propose to call uninit() before return; the
> point was that compared to calling it your idea would only save
> that single call even in the best case.

Then I misunderstood you originally, my apologies.

> > err=new->info->open(new);
> > if (err == AF_FATAL)
> > 	new->info->uninit(new);
> > else {
> > 	//...
> > }
>
> And as I wrote above, this would at most help avoid a single
> uninit() call per AF_FATAL use. If by your above "affects all
> filters at once" you mean that the change to af.c would
> immediately help all filters without working on them
> individually then I disagree. Currently nothing uses AF_FATAL,
> and suddenly starting to call uninit() after other errors
> without checking the filters individually would not be safe.

Of course filters should be corrected and their uninit functions 
should be verified to do proper work.

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090329/629410cf/attachment.pgp>