[MPlayer-dev-eng] [PATCH] get rid of af_msg (Was: Re: [PATCH] libbs2b audio filter)

Diego Biurrun diego at biurrun.de
Sat Mar 28 19:34:53 CET 2009


On Sat, Mar 28, 2009 at 03:49:27PM +0100, Reimar Döffinger wrote:
> On Sat, Mar 28, 2009 at 04:27:04AM +0100, Diego Biurrun wrote:
> > On Sat, Mar 28, 2009 at 06:07:13AM +0300, Andrew Savchenko wrote:
> > > --- libaf/af_channels.c	(revision 29079)
> > > +++ libaf/af_channels.c	(working copy)
> > > @@ -108,7 +108,7 @@
> > >    default:
> > > -    af_msg(AF_MSG_ERROR,"[channels] Unsupported number of bytes/sample: %i" 
> > > +    mp_msg(MSGT_AFILTER,MSGL_ERR,"[channels] Unsupported number of bytes/sample: %i" 
> > 
> > Please put a space after the commas, otherwise the patch is fine with
> > me, Reimar?
> 
> I think last time someone (Alex?) complained because libaf was supposed
> to compile/be usable standalone outside MPlayer.
> Personally I have no objections though.

Alex complained years ago, but he is not active anymore and I don't see
how having multiple message systems instead of one is making things
better.

I say apply, Reimar agrees, go ahead..

Diego



More information about the MPlayer-dev-eng mailing list