[MPlayer-dev-eng] [PATCH]Support IMGFMT_BGRA in vo vdpau

[Reimar Döffinger]

On Sat, Mar 28, 2009 at 01:31:45PM +0000, Carl Eugen Hoyos wrote:
> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> > Don't you think that users might actually
> > _prefer_ if MPlayer converts it to YV12 like it does currently, because
> > at least they get brightness/contrast/etc. control (which your patch would
> > actually break silently!), denoising, sharpening etc. pp.?
> 
> But shouldn't they get at least the possibility to use BGRA?
> I have to use scale anyway to be able to use it for something else than
> raw-video, so I don't think it can be used accidentally.

Huh? There are video formats that decoder to BGR/RGB natively,
especially many of the binary codecs, I have not checked but it might
even be possible that this change might cause some to decode to BGR
instead of YV12, loosing features for no real advantage.
Also, your patch does not show the whole amount of code necessary,
you'd at least need special-cases for VOCTRL_SET_EQUALIZER,
and VOCTRL_SET_DEINTERLACE.
IMHO if this is desirable it would be NVidia's job to add support for
RGB video surfaces.
Also IMO If you want to improve format support, IMGFMT_444P and
IMGFMT_422P would be more worthy formats...