[MPlayer-dev-eng] [PATCH] get rid of af_msg (Was: Re: [PATCH] libbs2b audio filter)

[Diego Biurrun]

On Sat, Mar 28, 2009 at 06:07:13AM +0300, Andrew Savchenko wrote:
> 
> On Friday 27 March 2009 01:18, Diego Biurrun wrote:
> [...]
> > > > This patch reminded me, why do we still have this af_msg
> > > > special-casing?
> > >
> > > I have absolutely no idea. It is defined at af.h, it is not
> > > marked as deprecated, it is used widely in other peaces of
> > > code; so I used it for consistency.
> > >
> > > Now I replaced them by mp_msg, because newly introduced
> > > af_stats filter do the same. Perhaps af_msg should be declared
> > > deprecated and removed from other audio filters.
> >
> > Any volunteers to remove all of them? :)
> 
> Done. Patch is large but straightworward, so I don't split it.
> 
> BTW, do we really need af_mp.h as a separate header file?
> It may be easly included in af.h

Fine with me..

> --- libaf/af_channels.c	(revision 29079)
> +++ libaf/af_channels.c	(working copy)
> @@ -108,7 +108,7 @@
>    default:
> -    af_msg(AF_MSG_ERROR,"[channels] Unsupported number of bytes/sample: %i" 
> +    mp_msg(MSGT_AFILTER,MSGL_ERR,"[channels] Unsupported number of bytes/sample: %i" 

Please put a space after the commas, otherwise the patch is fine with
me, Reimar?

Diego