[MPlayer-dev-eng] [PATCH] get rid of af_msg (Was: Re: [PATCH] libbs2b audio filter)

Andrew Savchenko bircoph at gmail.com
Sat Mar 28 04:07:13 CET 2009


Hi,

On Friday 27 March 2009 01:18, Diego Biurrun wrote:
[...]
> > > This patch reminded me, why do we still have this af_msg
> > > special-casing?
> >
> > I have absolutely no idea. It is defined at af.h, it is not
> > marked as deprecated, it is used widely in other peaces of
> > code; so I used it for consistency.
> >
> > Now I replaced them by mp_msg, because newly introduced
> > af_stats filter do the same. Perhaps af_msg should be declared
> > deprecated and removed from other audio filters.
>
> Any volunteers to remove all of them? :)

Done. Patch is large but straightworward, so I don't split it.

BTW, do we really need af_mp.h as a separate header file?
It may be easly included in af.h

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libaf-mp_msg.patch
Type: text/x-diff
Size: 49723 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090328/b768a53c/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090328/b768a53c/attachment.pgp>


More information about the MPlayer-dev-eng mailing list