[MPlayer-dev-eng] [PATCH] libbs2b audio filter

[Reimar Döffinger]

On Wed, Mar 25, 2009 at 10:06:28PM +0300, Andrew Savchenko wrote:
> I attached configure patch to one of previous e-mails. However, 
> after recent configure changes by Diego patch should be updated 
> due to renaming of some variables. New version is attached. I'll 
> apply it after review together with two other patches: filter 
> itself and documentation, posted earlier.

Good, I'll leave it to Diego to review that part.

> But using goto operator in C code... whilst this is technically 
> allowable I really dislike this kind of approach, it is ugly.

IMHO you should reconsider your conclusion of "ugly". Or would you
refuse to use exceptions in C++?
The kernel developers allow/recommend goto as well for that kind of
cleanup operation, for this same reason, there is no really comparably
maintainable way to do cleanup. Within MPlayer there has been (and
probably still is) quite a bit of code that shows the price of avoiding
it too much.
That said, it is a good idea to think about which uses of goto are
likely to lead to chaos and which seem overall reasonable and not use it
carelessly, but that applies to almost everything, there are ways to get
the same effects as a goto without using it, and they are truly scary...