[MPlayer-dev-eng] [PATCH] libbs2b audio filter

[Andrew Savchenko]

Hi,

On Monday 23 March 2009 21:52, Reimar Döffinger wrote:
> On Mon, Mar 23, 2009 at 06:27:42PM +0300, Andrew Savchenko wrote:
> > IMO the best solution is to replace all occurences of
> > malloc/calloc/realloc to their safe wrappers, e.g.
> > xmalloc/xcalloc/xrealloc with return value check and fatal
> > error message and exit() call if NULL is returned; if sane
> > exit attempt is really necessary, signal may be issued and
> > later proceed by sighandler. I do not know why this approach
> > isn't used throughout all mplayer's code.
>
> What is it supposed to gain? The error message? It's
> questionable if it will be possible to print it.

The smaller code is, the higher is probability. Also this may help 
to identify the reason of the problem.

> I complained 
> about the checks like you did them because while they are little
> code, the gains are even less IMHO, and both no code or a little
> bit more code to do it right seem like much more sensible in the
> effort vs. gain comparison.

Then I choose little more code ;-)

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libbs2b-filter-v8.patch
Type: text/x-diff
Size: 7600 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090323/b77359f0/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090323/b77359f0/attachment.pgp>