[MPlayer-dev-eng] [PATCH] libbs2b audio filter

[Reimar Döffinger]

On Mon, Mar 23, 2009 at 06:27:42PM +0300, Andrew Savchenko wrote:
> IMO the best solution is to replace all occurences of 
> malloc/calloc/realloc to their safe wrappers, e.g. 
> xmalloc/xcalloc/xrealloc with return value check and fatal error 
> message and exit() call if NULL is returned; if sane exit attempt 
> is really necessary, signal may be issued and later proceed by 
> sighandler. I do not know why this approach isn't used throughout 
> all mplayer's code.

What is it supposed to gain? The error message? It's questionable if it
will be possible to print it. I complained about the checks like you did
them because while they are little code, the gains are even less IMHO,
and both no code or a little bit more code to do it right seem like much
more sensible in the effort vs. gain comparison.