[MPlayer-dev-eng] [PATCH] Improved MMS over TCP support

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Mar 17 20:06:34 CET 2009


On Tue, Mar 17, 2009 at 06:05:33PM +0100, Francesco Cosoleto wrote:
> Francesco Cosoleto wrote:
> >> Attachment (mmst.diff): text/x-patch, 13 KiB
> > 
> > Attached patch contains a slipped out cosmetic change in begin
> > of the file. I'll remove it passed first review if requested.
> 
> Ping? Please, patch is intentionally short and removes very old ugly 
> buggy code and recent hack...

Sorry, but there is no way I can consider that patch "short", and that
it rewrites code makes it near impossible to check the code for
regressions nor do we have a regression test for mms (well, for MPlayer
we actually don't have any regression tests :-( ).
So unless someone else reviews it or applies it hoping for good luck it
won't break much it will have to wait till I have that much time.
As I understand the description it fixes several separate issues,
separating the patches will make reviewing and fixing regressions
easier, too.



More information about the MPlayer-dev-eng mailing list