[MPlayer-dev-eng] [PATCH] vo_kva

Diego Biurrun diego at biurrun.de
Sat Mar 14 18:31:51 CET 2009


On Sun, Mar 15, 2009 at 02:22:59AM +0900, KO Myung-Hun wrote:
> Hi/2.
>
> Diego Biurrun wrote:
>> On Sun, Mar 15, 2009 at 01:17:08AM +0900, KO Myung-Hun wrote:
>>   
>>> Reimar Döffinger wrote:
>>>     
>>>> If Diego is fine with the build system stuff I'd say it can be applied, if
>>>> before or after you send a patch that adds/includes the comments I
>>>> suggested that would be great.
>>>>       
>>> Ok. I added some more comments.
>>>
>>> --- libvo/vo_kva.c	(revision 0)
>>> +++ libvo/vo_kva.c	(revision 0)
>>> @@ -0,0 +1,1086 @@
>>> +// frame window procesure to workaround for T23 laptop with S3 video card
>>
>> I don't understand this, what is "procesure"?  It's not an English word..
>
> It should be 'procedure'.

OK, so now we have

  // frame window procesure to workaround for T23 laptop with S3 video card

First off, it should be ".. work around T23 ..", but this whole comment
does not yet make much sense.  Work around what?  A laptop is obviously
not what is worked around, there must be some sort of quirk that this
machine displays.  Please be more specific.

>> Note that I will not torture you any longer after this, but apply an
>> updated patch right away :)
>
> Oh~~~ Thanks. ^________^

I'm afraid we will have to work out what that comment means first,
please have a bit more patience... :-)

Diego



More information about the MPlayer-dev-eng mailing list