[MPlayer-dev-eng] [PATCH] Clarify current manpage description of -correct-pts functionality.

[Diego Biurrun]

On Mon, Feb 23, 2009 at 03:14:39PM -0500, Eric Appleman wrote:
> Fixed a grammatical error of my previous patch and added entry for  
> -nocorrect-pts.

Ideally these patches should go to mplayer-docs, but never mind now.

> --- mplayer.1	(revision 28690)
> +++ mplayer.1	(working copy)
> @@ -834,6 +834,9 @@
>  subtitles timed to scene changes with the \-ass option.
>  Without \-correct\-pts the subtitle timing will typically be off by some frames.
>  This option does not work correctly with some demuxers and codecs.
> +If not explicitly called for in the command line,
> +MPlayer will either enable or disable \-correct\-pts upon determining 
> +whether or not the file being played uses a supported demuxer and/or codec.

I don't understand this.  "called for"?

> @@ -1055,6 +1058,12 @@
>  .
>  .TP
> +.B \-nocorrect\-pts
> +Turns off correct\-pts even if MPlayer would otherwise 
> +enable the option if the muxer or codec for a given video supported it.

As a rule of thumb, we do not document the -nofoo versions of -foo flag
options.  Do you see a reason why we should here?  Also, in those special
cases, the -nofoo version should be placed right after -foo, violating
alphabetical order.

Diego

P.S.: Please just attach your patches, the inline version gets mangled.