[MPlayer-dev-eng] [PATCH] vo_kva

[Diego Biurrun]

On Sun, Mar 15, 2009 at 01:17:08AM +0900, KO Myung-Hun wrote:
>
> Reimar Döffinger wrote:
>> If Diego is fine with the build system stuff I'd say it can be applied, if
>> before or after you send a patch that adds/includes the comments I
>> suggested that would be great.
>
> Ok. I added some more comments.
>
> --- libvo/vo_kva.c	(revision 0)
> +++ libvo/vo_kva.c	(revision 0)
> @@ -0,0 +1,1086 @@
> +// frame window procesure to workaround for T23 laptop with S3 video card

I don't understand this, what is "procesure"?  It's not an English word..

> +        pti->ptlMinTrackSize.x = rcl.xRight - rcl.xLeft;
> +        pti->ptlMinTrackSize.y = rcl.yTop - rcl.yBottom;

nit: The right-hand-side could be aligned.

> +            pswp->cx  = rcl.xRight - rcl.xLeft;
> +            pswp->cy  = rcl.yTop - rcl.yBottom;

ditto

> +    // if slave mode, ignore mouse events and deliver them to a parent window
> +    if (WinID != -1 &&
> +        ((msg >= WM_MOUSEFIRST && msg <= WM_MOUSELAST) ||
> +         (msg >= WM_EXTMOUSEFIRST && msg <= WM_EXTMOUSELAST))) {

This could be aligned as well.

> +        // get rects from the region

rectangles

> +        // draw black-bar if needed

black bar

> +    WinRegisterClass(m_int.hab,
> +                     WC_MPLAYER,
> +                     WndProc,
> +                     CS_SIZEREDRAW | CS_MOVENOTIFY,
> +                     sizeof(PVOID));

nit: I don't see a need to use so many lines, but feel free to
ignore me...

> +        m_int.rclDst.xLeft   = ((LONG)vo_screenwidth - (LONG)d_width) / 2;
> +        m_int.rclDst.yBottom = ((LONG)vo_screenheight - (LONG)d_height) /2 ;
> +        m_int.rclDst.xRight  = m_int.rclDst.xLeft + d_width;
> +        m_int.rclDst.yTop    = m_int.rclDst.yBottom + d_height;

anothe candidate for right-hand-side alignment

> +        rcl.xLeft   = ((LONG)vo_screenwidth - (LONG)d_width) / 2;
> +        rcl.yBottom = ((LONG)vo_screenheight - (LONG)d_height) /2 ;
> +        rcl.xRight  = rcl.xLeft + d_width;
> +        rcl.yTop    = rcl.yBottom + d_height;

ditto

> +        m_int.rclDst.xRight  = m_int.rclDst.xLeft + swp.cx;
> +        m_int.rclDst.yTop    = m_int.rclDst.yBottom + swp.cy;

and another


Note that I will not torture you any longer after this, but apply an
updated patch right away :)

Diego