[MPlayer-dev-eng] [PATCH] use libavutil fifo.h in ao_macosx.c

Guillaume POIRIER poirierg at gmail.com
Mon Mar 9 23:35:15 CET 2009


On Mon, Mar 9, 2009 at 11:17 PM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Mon, Mar 09, 2009 at 10:33:57PM +0100, Guillaume POIRIER wrote:
>> On Mon, Mar 9, 2009 at 7:49 PM, Reimar Döffinger
>> <Reimar.Doeffinger at gmx.de> wrote:
>> > Hello,
>> > I can not test it but this patch changes ao_macosx to use
>> > libavutil/fifo.h like ao_sdl and ao_jack.
>>
>> This breaks at link stage, but I don't know why right now:
>
> Fixed, but oh dear, more uselessly duplicated code: the amount of data
> read is limited to the data in the fifo in read_buffer and in the
> function read_buffer, and uninit duplicates get_delay code, even though
> using get_delay would even make more sense semantically...

Thanks. This code doesn't work as expected: the player hangs at the
first frame with this status line:

VO: [macosx] 720x400 => 720x400 Packed YUY2
Get device error: Device ID -1 does not exist, falling back to main device.
A:  -0.0 V:   0.2 A-V: -0.163 ct: -0.012   5/  5 ??% ??% ??,?% 0 0


If I seek forward in the file, the player "de-hangs" and plays the
movie file just fine.

Cheers,


Guillaume


-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Ted Turner  - "Sports is like a war without the killing."



More information about the MPlayer-dev-eng mailing list