[MPlayer-dev-eng] feature XInput

[Uoti Urpala]

On Sat, 2009-03-07 at 23:00 +0100, Reimar Döffinger wrote:
> On Sat, Mar 07, 2009 at 10:48:56PM +0100, Christoph Fritz wrote:
> > +    xic.M = (XDeviceMotionEvent *) & xic.event;
> > +    xic.B = (XDeviceButtonEvent *) & xic.event;
> > +    xic.dpy = XOpenDisplay(NULL);
> > +    XDeviceInfoPtr list;
> 
> Mixing code and declarations. Read the compiler warnings.

Nothing wrong with mixing them.

> But more importantly:
> that might not be the display MPlayer is running on.
> Are you really sure this is what you want?
> And as a corollary to that: Are you really sure this does not belong in
> libvo/x11_common.c?

The input is independent of any window and so using it can make sense
even if MPlayer has no output window. It would be possible to use a
shared X connection for everything under MPlayer (thus also ensuring
that the same display is used in all cases, though multiple usable
displays is probably a marginal use case), but that would require
changing various other stuff. I don't know of any real problems that
using a separate X connection for the input would cause, so I think this
is preferable at least to a simple x11_common version that would lose
the ability to get input when playing audio files or otherwise having no
X11 vo.