[MPlayer-dev-eng] [PATCH] libbs2b audio filter

Andrew Savchenko bircoph at gmail.com
Sat Mar 7 23:39:46 CET 2009


Hi,

On Saturday 07 March 2009 15:40, Reimar Döffinger wrote:
> On Sat, Mar 07, 2009 at 02:10:17PM +0200, Uoti Urpala wrote:
> > I think using a switch to make a "clean" solution would not be
> > too cumbersome in this case. It's possible this would worsen
> > performance, but that's only because of the existing already
> > ridiculously inefficient function-call-per-sample usage. If
> > that main inefficiency is fixed later then the switch will
> > have no performance impact either.
>
> Well, there is no (relevant) performance problem if you just
> duplicate the loop, too. It's a bit ugly, but on the other hand
> it gets rid of the need for that bytes-per-sample calculation.

What if I go little further and will create different play 
functions for different audio data types? It shouldn't 
significantly differ from loop duplication.

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libbs2b-filter-v4.patch
Type: text/x-diff
Size: 10100 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090308/2fe9dc72/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090308/2fe9dc72/attachment.pgp>


More information about the MPlayer-dev-eng mailing list